[all-commits] [llvm/llvm-project] 3b3560: [llvm-readobj] - Always print "Predecessors" for v...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Wed Nov 27 01:31:14 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3b35603a56b2dcc7fb0480d8d4c4aeacacecf1fb
      https://github.com/llvm/llvm-project/commit/3b35603a56b2dcc7fb0480d8d4c4aeacacecf1fb
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2019-11-27 (Wed, 27 Nov 2019)

  Changed paths:
    M lld/test/ELF/verdef-defaultver.s
    M lld/test/ELF/verdef-dependency.s
    M lld/test/ELF/verdef.s
    M llvm/test/tools/llvm-readobj/elf-versioninfo.test
    M llvm/test/tools/yaml2obj/ELF/verdef-section.yaml
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readobj] - Always print "Predecessors" for version definition sections.

This is a follow-up discussed in D70495 thread.

The current logic is unusual for llvm-readobj. It doesn't print predecessors
list when it is empty. This is not good for machine parsers.
D70495 had to add this condition during refactoring to reduce amount of changes,
in tests, because the original code also had a similar logic.

Now seems it is time to get rid of it. This patch does it.

Differential revision: https://reviews.llvm.org/D70717




More information about the All-commits mailing list