[all-commits] [llvm/llvm-project] a19555: [JumpThreading] NFC: Don't cache F.hasProfileData()

kazutakahirata via All-commits all-commits at lists.llvm.org
Fri Nov 22 08:52:20 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a1955566282b98d5182877860b60d04029089788
      https://github.com/llvm/llvm-project/commit/a1955566282b98d5182877860b60d04029089788
  Author: Kazu Hirata <kazu at google.com>
  Date:   2019-11-22 (Fri, 22 Nov 2019)

  Changed paths:
    M llvm/lib/Transforms/Scalar/JumpThreading.cpp

  Log Message:
  -----------
  [JumpThreading] NFC: Don't cache F.hasProfileData()

Summary:
With this patch, we no longer cache F.hasProfileData().  We simply
call the function again.

I'm doing this because:

- JumpThreadingPass also has a member variable named HasProfileData,
  which is very confusing,

- the function is very lightweight, and

- this patch makes JumpThreading::runOnFunction more consistent with
  JumpThreadingPass::run.

Subscribers: hiraditya, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70602




More information about the All-commits mailing list