[all-commits] [llvm/llvm-project] 0b3d1d: [coroutines] Remove assert on CoroutineParameterMo...

Brian Gesiak via All-commits all-commits at lists.llvm.org
Fri Nov 22 08:42:40 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f
      https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f
  Author: Brian Gesiak <modocache at gmail.com>
  Date:   2019-11-22 (Fri, 22 Nov 2019)

  Changed paths:
    M clang/lib/Sema/SemaCoroutine.cpp
    M clang/test/SemaCXX/coroutines.cpp

  Log Message:
  -----------
  [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

Summary:
The assertion of CoroutineParameterMoves happens when build coroutine function with arguments  multiple time while fails to build promise type.

Fix: use return false instead.

Test Plan: check-clang

Reviewers: modocache, GorNishanov, rjmccall

Reviewed By: modocache

Subscribers: rjmccall, EricWF, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69022

Patch by junparser (JunMa)!




More information about the All-commits mailing list