[all-commits] [llvm/llvm-project] f471eb: [FileCheck] Make FILECHECK_OPTS useful for its tes...

[Joel E. Denny via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f471eb8e99b564265a4bea326922263ff06cda40
      https://github.com/llvm/llvm-project/commit/f471eb8e99b564265a4bea326922263ff06cda40
  Author: Joel E. Denny <jdenny.ornl at gmail.com>
  Date:   2019-11-21 (Thu, 21 Nov 2019)

  Changed paths:
    M llvm/docs/TestingGuide.rst
    M llvm/test/FileCheck/check-count.txt
    M llvm/test/FileCheck/check-empty-tag.txt
    M llvm/test/FileCheck/check-empty.txt
    M llvm/test/FileCheck/check-ignore-case.txt
    M llvm/test/FileCheck/check-label-dag.txt
    M llvm/test/FileCheck/check-label.txt
    M llvm/test/FileCheck/check-multiple-prefixes-nomatch-2.txt
    M llvm/test/FileCheck/check-multiple-prefixes-nomatch.txt
    M llvm/test/FileCheck/check-not-diaginfo.txt
    M llvm/test/FileCheck/check-prefixes.txt
    M llvm/test/FileCheck/dump-input-annotations.txt
    M llvm/test/FileCheck/dump-input-enable.txt
    M llvm/test/FileCheck/envvar-opts.txt
    M llvm/test/FileCheck/implicit-check-not.txt
    M llvm/test/FileCheck/line-count.txt
    M llvm/test/FileCheck/lit.local.cfg
    M llvm/test/FileCheck/match-full-lines.txt
    M llvm/test/FileCheck/multiple-missing-prefixes.txt
    M llvm/test/FileCheck/no-check-file.txt
    M llvm/test/FileCheck/no-multi-suffixes.txt
    M llvm/test/FileCheck/numeric-defines-diagnostics.txt
    M llvm/test/FileCheck/numeric-defines.txt
    M llvm/test/FileCheck/numeric-expression.txt
    M llvm/test/FileCheck/opt-color.txt
    M llvm/test/FileCheck/string-defines-diagnostics.txt
    M llvm/test/FileCheck/string-defines.txt
    M llvm/test/FileCheck/validate-check-prefix.txt
    M llvm/test/FileCheck/var-scope.txt
    M llvm/test/FileCheck/verbose.txt

  Log Message:
  -----------
  [FileCheck] Make FILECHECK_OPTS useful for its test suite

Without this patch, `FILECHECK_OPTS` isn't propagated to FileCheck's
test suite so that `FILECHECK_OPTS` doesn't inadvertently affect test
results by affecting the output of FileCheck calls under test.  As a
result, `FILECHECK_OPTS` is useless for debugging FileCheck's test
suite.

In `llvm/test/FileCheck/lit.local.cfg`, this patch provides a new
subsitution, `%ProtectFileCheckOutput`, to address this problem for
both `FILECHECK_OPTS` and the deprecated
`FILECHECK_DUMP_INPUT_ON_FAILURE`.  The rest of the patch uses
`%ProtectFileCheckOutput` throughout the test suite

Fixes PR40284.

Reviewed By: probinson, thopre

Differential Revision: https://reviews.llvm.org/D65121