[all-commits] [llvm/llvm-project] fcd160: [lldb-vscode] support the completion request

walter erquinigo via All-commits all-commits at lists.llvm.org
Fri Nov 15 17:29:20 PST 2019


  Branch: refs/heads/completion
  Home:   https://github.com/llvm/llvm-project
  Commit: fcd1604ccdd0acba6ca8a31a2ee7fa0b465fbccb
      https://github.com/llvm/llvm-project/commit/fcd1604ccdd0acba6ca8a31a2ee7fa0b465fbccb
  Author: Walter Erquinigo <waltermelon at oculus.com>
  Date:   2019-11-15 (Fri, 15 Nov 2019)

  Changed paths:
    A lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/Makefile
    A lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py
    A lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/main.cpp
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  [lldb-vscode] support the completion request

Summary:
The DAP has a completion request that has been unimplemented. It allows showing autocompletion tokens inside the Debug Console.
I implemented it in a very simple fashion mimicking what the user would see when autocompleting an expression inside the CLI.
There are two cases: normal variables and commands. The latter occurs when a text is prepepended with ` in the Debug Console.
These two cases work well and have tests.

Reviewers: clayborg, aadsm

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D69873




More information about the All-commits mailing list