[all-commits] [llvm/llvm-project] 1ee18f: [dsymutil] Add support for linking remarks

Visoiu Mistrih Francis via All-commits all-commits at lists.llvm.org
Fri Nov 1 15:38:58 PDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ee18f275e60462d8c5e149fc74eaea9c671d4a8
      https://github.com/llvm/llvm-project/commit/1ee18f275e60462d8c5e149fc74eaea9c671d4a8
  Author: Francis Visoiu Mistrih <francisvm at yahoo.com>
  Date:   2019-11-01 (Fri, 01 Nov 2019)

  Changed paths:
    M llvm/test/tools/dsymutil/Inputs/basic1.c
    A llvm/test/tools/dsymutil/Inputs/remarks/basic.macho.remarks.x86_64
    A llvm/test/tools/dsymutil/Inputs/remarks/basic1.macho.remarks.x86_64.o
    A llvm/test/tools/dsymutil/Inputs/remarks/basic1.macho.remarks.x86_64.opt.bitstream
    A llvm/test/tools/dsymutil/Inputs/remarks/basic2.macho.remarks.x86_64.o
    A llvm/test/tools/dsymutil/Inputs/remarks/basic2.macho.remarks.x86_64.opt.bitstream
    A llvm/test/tools/dsymutil/Inputs/remarks/basic3.macho.remarks.x86_64.o
    A llvm/test/tools/dsymutil/Inputs/remarks/basic3.macho.remarks.x86_64.opt.bitstream
    A llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.i386.opt.bitstream
    A llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86
    A llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86.c
    A llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86.o
    A llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86.opt.bitstream
    A llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86_64.opt.bitstream
    A llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86_64h.opt.bitstream
    M llvm/test/tools/dsymutil/X86/basic-linking-bundle.test
    A llvm/test/tools/dsymutil/X86/remarks-linking-bundle.test
    A llvm/test/tools/dsymutil/X86/remarks-linking-fat-bundle.test
    M llvm/test/tools/dsymutil/cmdline.test
    M llvm/tools/dsymutil/CMakeLists.txt
    M llvm/tools/dsymutil/DwarfLinker.cpp
    M llvm/tools/dsymutil/LinkUtils.h
    M llvm/tools/dsymutil/Options.td
    M llvm/tools/dsymutil/dsymutil.cpp

  Log Message:
  -----------
  [dsymutil] Add support for linking remarks

This adds support to dsymutil for linking remark files and placing them
in the final .dSYM bundle.

The result will be placed in:

* a.out.dSYM/Contents/Resources/Remarks/a.out
or
* a.out.dSYM/Contents/Resources/Remarks/a.out-<arch> for universal binaries

When multi-threaded, this runs a third thread which loops over all the
object files and parses remarks as it finds __remarks sections.

Testing this involves running dsymutil on pre-built binaries and object
files, then running llvm-bcanalyzer on the final result to check for
remarks.

Differential Revision: https://reviews.llvm.org/D69142




More information about the All-commits mailing list